Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lubelogger)!: added persistence #15

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat(lubelogger)!: added persistence #15

merged 1 commit into from
Sep 12, 2024

Conversation

shanduur
Copy link
Contributor

@shanduur shanduur commented Sep 12, 2024

Description

This PR introduces a significant feature enhancement to the LubeLogger application Chart by adding support for persistent data, documents, and images storage, as well as introducing additional configuration improvements.

Major Changes:

  1. Persistent Volume Claims (PVC) for Data, Documents, and Images:

    • Added PVC configurations for data, documents, and images storage to enable persistence across container restarts.
    • Templates are updated to conditionally create PVCs if persistence.enabled is set to true and no existing claims are provided.
    • Deployment YAML updated to mount these PVCs within the container, allowing the application to store and retrieve data, documents, and images.
  2. Version Bump:

    • Chart version bumped to 0.3.0 to reflect breaking changes and the new feature additions.
  3. New Configurations:

    • Added userConfig in the values file, allowing users to specify detailed configuration options such as logging levels, authentication settings, and other.
    • Introduced translations configuration for loading translation files at runtime, enhancing internationalization capabilities.
  4. Secret Handling:

    • Updated secret templates to manage configuration for user-specific settings and improved mail secret handling.
    • New secret created for storing the user configuration (userConfig), providing better separation of sensitive data.
  5. Improved NOTES.txt:

    • Enhanced NOTES with warnings about potential data loss if replica count is set to more than 1, as data sync between replicas is not supported.
  6. Miscellaneous:

    • Minor updates to various templates, including helper files, to accommodate the new PVCs and the initContainers for handling translations.
    • Removed unnecessary dependencies from the Brewfile.

Breaking Changes:

  • The application now supports persistence, so any users who scale their deployment to multiple replicas must be aware of potential data inconsistencies, as data sync across replicas is not yet implemented.

Testing:

  • PVCs were successfully created and mounted for data, documents, and images.
  • Verified that translations are fetched and loaded correctly during initialization.
  • Tested application behavior with persistent storage across container restarts.

Resolves #14

@shanduur shanduur added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2024
@shanduur shanduur self-assigned this Sep 12, 2024
@shanduur shanduur changed the title feat: added persistence feat(lubelogger): added persistence Sep 12, 2024
@shanduur shanduur changed the title feat(lubelogger): added persistence feat(lubelogger)!: added persistence Sep 12, 2024
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur shanduur marked this pull request as ready for review September 12, 2024 10:00
@shanduur shanduur requested a review from a team as a code owner September 12, 2024 10:00
@shanduur shanduur merged commit 1fed878 into main Sep 12, 2024
6 checks passed
@shanduur shanduur deleted the feat-add-volumes branch September 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: No way to define volumes with this lubelogger chart so images/documents cannot be persisted
1 participant